Feature/271 redux #332
Merged
Feature/271 redux #332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #332 +/- ##
==========================================
+ Coverage 97.17% 97.20% +0.02%
==========================================
Files 35 35
Lines 991 1000 +9
==========================================
+ Hits 963 972 +9
Misses 28 28
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
woile
reviewed
Jan 15, 2021
|
Thanks :D |
cliles
force-pushed
the
feature/271-redux
branch
2 times, most recently
from
10543d7 to
44385ef
Compare
|
I see you pushed new changes but the docs were not updated 😅 Also the commit message should be |
cliles
force-pushed
the
feature/271-redux
branch
from
44385ef to
90a2acb
Compare
cliles
force-pushed
the
feature/271-redux
branch
from
90a2acb to
20a54bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As noted in #329 there exists an abandoned PR (#272) for annotated tag support. After reviewing #272 it looks like the only outstanding action was to rebase and revert CHANGELOG entries so they could be generated from CI?
I can not gain access to the original author's fork, but have simply carried the original work over and rebased and cleared CHANGELOG.
This is a very useful feature, so adoption seemed valid.
Checklist
./script/formatand./script/testlocally to ensure this change passes linter check and testExpected behavior
See original #272
Steps to Test This Pull Request
See original #272
Additional context
See original #271
See original #272